Remove Clustering #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +124,7 @@ describe('server', function() { | |||
| server.start.domain.removeListener('error', errorListener); | |||
| expect(monitor.increment.calledWith('error.unhandled')) | |||
| .to.be.true(); | |||
| expect(process.exit.calledOnce); | |||
There was a problem hiding this comment.
also expect histogram call?
There was a problem hiding this comment.
Cheeky, yeah let me add monitoring tests for that.
|
can we add a functional test which test the case which prompted this PR? |
|
I suppose so, though the code that was causing it was removed. |
|
@anandkumarpatel - Added. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an issue with node, we cannot use clustering for UDP in 0.12. Since it is only nice-to-have and not show-stopping, I opted to remove clustering for the time being in charon. Also, note that UDP clustering was added in v0.11.14, so we cannot rely on using 0.10.x to do this.
This PR removes clustering and adds
process.exit(1)to the domain error handler.